From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31990 [PATCH v3 1/5] bbdev: librte_bbdev library
Date: Thu, 7 Dec 2017 22:41:37 +0100 (CET) [thread overview]
Message-ID: <20171207214137.CB350199B4@dpdk.org> (raw)
In-Reply-To: <1512682857-79467-1-git-send-email-amr.mokhtar@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31990
_coding style issues_
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#55: FILE: MAINTAINERS:276:
+M: Amr Mokhtar <amr.mokhtar@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#56: FILE: MAINTAINERS:277:
+F: lib/librte_bbdev/
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#57: FILE: MAINTAINERS:278:
+F: drivers/bbdev/
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#58: FILE: MAINTAINERS:279:
+F: app/test-bbdev
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#59: FILE: MAINTAINERS:280:
+F: examples/bbdev_app/
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#60: FILE: MAINTAINERS:281:
+F: doc/guides/bbdevs/
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#61: FILE: MAINTAINERS:282:
+F: doc/guides/prog_guide/bbdev.rst
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#62: FILE: MAINTAINERS:283:
+F: doc/guides/sample_app_ug/bbdev_app.rst
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#63: FILE: MAINTAINERS:284:
+F: doc/guides/tools/testbbdev.rst
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#258: FILE: lib/librte_bbdev/rte_bbdev.c:59:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+ if (dev == NULL) { \
+ rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+ return -ENODEV; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#266: FILE: lib/librte_bbdev/rte_bbdev.c:67:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+ if (dev->dev_ops == NULL) { \
+ rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+ dev_id); \
+ return -ENODEV; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#275: FILE: lib/librte_bbdev/rte_bbdev.c:76:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+ if (func == NULL) { \
+ rte_bbdev_log(ERR, "device %u does not support %s", \
+ dev_id, #func); \
+ return -ENOTSUP; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#284: FILE: lib/librte_bbdev/rte_bbdev.c:85:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+ if (queue_id >= dev->data->num_queues) { \
+ rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+ queue_id, dev->data->dev_id); \
+ return -ERANGE; \
+ } \
+} while (0)
total: 0 errors, 13 warnings, 3320 lines checked
parent reply other threads:[~2017-12-07 21:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1512682857-79467-1-git-send-email-amr.mokhtar@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207214137.CB350199B4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=amr.mokhtar@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).