automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw32009 [PATCH 13/14] net/dpaa2: optimize Tx path for best case
Date: Fri,  8 Dec 2017 06:24:14 +0100 (CET)	[thread overview]
Message-ID: <20171208052414.A83D21B03C@dpdk.org> (raw)
In-Reply-To: <1512710487-32388-14-git-send-email-hemant.agrawal@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32009

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#46: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:53:
+#define DPAA2_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, _mbuf->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, _bpid); \
+	DPAA2_SET_FD_OFFSET(_fd, _mbuf->data_off); \
+	DPAA2_SET_FD_ASAL(_fd, DPAA2_ASAL_VAL); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#46: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:53:
+#define DPAA2_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, _mbuf->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, _bpid); \
+	DPAA2_SET_FD_OFFSET(_fd, _mbuf->data_off); \
+	DPAA2_SET_FD_ASAL(_fd, DPAA2_ASAL_VAL); \
+} while (0)

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#100: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:736:
+						if (ret)

total: 0 errors, 1 warnings, 2 checks, 93 lines checked

           reply	other threads:[~2017-12-08  5:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1512710487-32388-14-git-send-email-hemant.agrawal@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208052414.A83D21B03C@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).