From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A83D21B03C; Fri,  8 Dec 2017 06:24:14 +0100 (CET)
In-Reply-To: <1512710487-32388-14-git-send-email-hemant.agrawal@nxp.com>
References: <1512710487-32388-14-git-send-email-hemant.agrawal@nxp.com>
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-Id: <20171208052414.A83D21B03C@dpdk.org>
Date: Fri,  8 Dec 2017 06:24:14 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32009 [PATCH 13/14] net/dpaa2:
	optimize Tx path for best case
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 05:24:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32009

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#46: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:53:
+#define DPAA2_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, _mbuf->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, _bpid); \
+	DPAA2_SET_FD_OFFSET(_fd, _mbuf->data_off); \
+	DPAA2_SET_FD_ASAL(_fd, DPAA2_ASAL_VAL); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#46: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:53:
+#define DPAA2_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, _mbuf->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, _bpid); \
+	DPAA2_SET_FD_OFFSET(_fd, _mbuf->data_off); \
+	DPAA2_SET_FD_ASAL(_fd, DPAA2_ASAL_VAL); \
+} while (0)

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#100: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:736:
+						if (ret)

total: 0 errors, 1 warnings, 2 checks, 93 lines checked