From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Xueming Li <xuemingl@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw32024 [PATCH RFC v1 7/9] app/testpmd: add pktgen engine scapy commands
Date: Fri, 8 Dec 2017 09:24:39 +0100 (CET) [thread overview]
Message-ID: <20171208082439.8C48E1B040@dpdk.org> (raw)
In-Reply-To: <20171208082225.44913-8-xuemingl@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32024
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#65: FILE: app/test-pmd/cmdline.c:15598:
+extern cmdline_parse_inst_t cmd_expect_short;
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#66: FILE: app/test-pmd/cmdline.c:15599:
+extern cmdline_parse_inst_t cmd_expect;
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#67: FILE: app/test-pmd/cmdline.c:15600:
+extern cmdline_parse_inst_t cmd_tx;
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#68: FILE: app/test-pmd/cmdline.c:15601:
+extern cmdline_parse_inst_t cmd_tx_short;
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#69: FILE: app/test-pmd/cmdline.c:15602:
+extern cmdline_parse_inst_t cmd_rx;
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#70: FILE: app/test-pmd/cmdline.c:15603:
+extern cmdline_parse_inst_t cmd_rx_short;
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#105: FILE: app/test-pmd/pktgen.c:570:
+#define US_TSC(us) ((us) * (rte_get_timer_hz() / 1000000L));
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#133: FILE: app/test-pmd/pktgen.c:598:
+ struct pktgen_task* task;
ERROR:SPACING: space required before the open parenthesis '('
#206: FILE: app/test-pmd/pktgen.c:671:
+ while(m)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#227: FILE: app/test-pmd/pktgen.c:692:
+ if (cmd->field && strlen(cmd->field)) {
+ task->field = cmd->field;
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#236: FILE: app/test-pmd/pktgen.c:701:
+cmd_pg_tx(struct cmd_pktgen_cmd* cmd, int txrx)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#257: FILE: app/test-pmd/pktgen.c:722:
+cmd_pg_wait(struct cmdline *cl, struct cmd_pktgen_cmd* cmd,
WARNING:SPACING: space prohibited before semicolon
#337: FILE: app/test-pmd/pktgen.c:802:
+ timeout = rte_rdtsc() + US_TSC(cmd->rx.timeout * 1000) ;
WARNING:MISSING_SPACE: break quoted strings at a space character
#360: FILE: app/test-pmd/pktgen.c:825:
+ printf("%s"
+ "tx: %lu/%lu %.3fus %fmpps"
total: 4 errors, 10 warnings, 570 lines checked
parent reply other threads:[~2017-12-08 8:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171208082225.44913-8-xuemingl@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208082439.8C48E1B040@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).