From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 8C48E1B040; Fri,  8 Dec 2017 09:24:39 +0100 (CET)
In-Reply-To: <20171208082225.44913-8-xuemingl@mellanox.com>
References: <20171208082225.44913-8-xuemingl@mellanox.com>
To: test-report@dpdk.org
Cc: Xueming Li <xuemingl@mellanox.com>
Message-Id: <20171208082439.8C48E1B040@dpdk.org>
Date: Fri,  8 Dec 2017 09:24:39 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32024 [PATCH RFC v1 7/9]
	app/testpmd: add pktgen engine scapy commands
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 08:24:40 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32024

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#65: FILE: app/test-pmd/cmdline.c:15598:
+extern cmdline_parse_inst_t cmd_expect_short;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#66: FILE: app/test-pmd/cmdline.c:15599:
+extern cmdline_parse_inst_t cmd_expect;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#67: FILE: app/test-pmd/cmdline.c:15600:
+extern cmdline_parse_inst_t cmd_tx;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#68: FILE: app/test-pmd/cmdline.c:15601:
+extern cmdline_parse_inst_t cmd_tx_short;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#69: FILE: app/test-pmd/cmdline.c:15602:
+extern cmdline_parse_inst_t cmd_rx;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#70: FILE: app/test-pmd/cmdline.c:15603:
+extern cmdline_parse_inst_t cmd_rx_short;

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#105: FILE: app/test-pmd/pktgen.c:570:
+#define US_TSC(us) ((us) * (rte_get_timer_hz() / 1000000L));

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#133: FILE: app/test-pmd/pktgen.c:598:
+	struct pktgen_task* task;

ERROR:SPACING: space required before the open parenthesis '('
#206: FILE: app/test-pmd/pktgen.c:671:
+		while(m)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#227: FILE: app/test-pmd/pktgen.c:692:
+		if (cmd->field && strlen(cmd->field)) {
+				task->field = cmd->field;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#236: FILE: app/test-pmd/pktgen.c:701:
+cmd_pg_tx(struct cmd_pktgen_cmd* cmd, int txrx)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#257: FILE: app/test-pmd/pktgen.c:722:
+cmd_pg_wait(struct cmdline *cl, struct cmd_pktgen_cmd* cmd,

WARNING:SPACING: space prohibited before semicolon
#337: FILE: app/test-pmd/pktgen.c:802:
+		timeout = rte_rdtsc() + US_TSC(cmd->rx.timeout * 1000) ;

WARNING:MISSING_SPACE: break quoted strings at a space character
#360: FILE: app/test-pmd/pktgen.c:825:
+		printf("%s"
+			"tx: %lu/%lu %.3fus %fmpps"

total: 4 errors, 10 warnings, 570 lines checked