From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-test-report] |WARNING| pw32184 [PATCH 2/7] event/octeontx: modify octeontx eventdev test
Date: Tue, 12 Dec 2017 20:28:36 +0100 (CET) [thread overview]
Message-ID: <20171212192836.DFCA71B19F@dpdk.org> (raw)
In-Reply-To: <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32184
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#39: FILE: drivers/event/octeontx/selftest_octeontx.c:55:
+#define ASSERT(cond, msg, ...) do { \
+ if (!(cond)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#42: FILE: drivers/event/octeontx/selftest_octeontx.c:58:
+ msg , __func__, __LINE__, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#48: FILE: drivers/event/octeontx/selftest_octeontx.c:64:
+#define ASSERT_EQUAL(a, b, msg, ...) do { \
+ if (!(a == b)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#51: FILE: drivers/event/octeontx/selftest_octeontx.c:67:
+ msg , __func__, __LINE__, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#57: FILE: drivers/event/octeontx/selftest_octeontx.c:73:
+#define ASSERT_SUCCESS(val, msg, ...) do { \
+ typeof(val) _val = (val); \
+ if (!(_val == 0)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed (err %d): " \
+ msg , __func__, __LINE__, _val, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#61: FILE: drivers/event/octeontx/selftest_octeontx.c:77:
+ msg , __func__, __LINE__, _val, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#67: FILE: drivers/event/octeontx/selftest_octeontx.c:83:
+#define ASSERT_NOT_NULL(val, msg, ...) do { \
+ if (!(val != NULL)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#70: FILE: drivers/event/octeontx/selftest_octeontx.c:86:
+ msg , __func__, __LINE__, \
^
total: 4 errors, 4 warnings, 913 lines checked
parent reply other threads:[~2017-12-12 19:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212192836.DFCA71B19F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).