* [dpdk-test-report] |WARNING| pw32184 [PATCH 2/7] event/octeontx: modify octeontx eventdev test
[not found] <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>
@ 2017-12-12 19:28 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-12-12 19:28 UTC (permalink / raw)
To: test-report; +Cc: Pavan Bhagavatula
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32184
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#39: FILE: drivers/event/octeontx/selftest_octeontx.c:55:
+#define ASSERT(cond, msg, ...) do { \
+ if (!(cond)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#42: FILE: drivers/event/octeontx/selftest_octeontx.c:58:
+ msg , __func__, __LINE__, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#48: FILE: drivers/event/octeontx/selftest_octeontx.c:64:
+#define ASSERT_EQUAL(a, b, msg, ...) do { \
+ if (!(a == b)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#51: FILE: drivers/event/octeontx/selftest_octeontx.c:67:
+ msg , __func__, __LINE__, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#57: FILE: drivers/event/octeontx/selftest_octeontx.c:73:
+#define ASSERT_SUCCESS(val, msg, ...) do { \
+ typeof(val) _val = (val); \
+ if (!(_val == 0)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed (err %d): " \
+ msg , __func__, __LINE__, _val, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#61: FILE: drivers/event/octeontx/selftest_octeontx.c:77:
+ msg , __func__, __LINE__, _val, \
^
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#67: FILE: drivers/event/octeontx/selftest_octeontx.c:83:
+#define ASSERT_NOT_NULL(val, msg, ...) do { \
+ if (!(val != NULL)) { \
+ ssovf_log_dbg("Assert failed %s() line %d failed : " \
+ msg , __func__, __LINE__, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#70: FILE: drivers/event/octeontx/selftest_octeontx.c:86:
+ msg , __func__, __LINE__, \
^
total: 4 errors, 4 warnings, 913 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-12-12 19:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>
2017-12-12 19:28 ` [dpdk-test-report] |WARNING| pw32184 [PATCH 2/7] event/octeontx: modify octeontx eventdev test checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).