From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DFCA71B19F; Tue, 12 Dec 2017 20:28:36 +0100 (CET)
In-Reply-To: <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>
References: <20171212192713.17620-2-pbhagavatula@caviumnetworks.com>
To: test-report@dpdk.org
Cc: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
Message-Id: <20171212192836.DFCA71B19F@dpdk.org>
Date: Tue, 12 Dec 2017 20:28:36 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32184 [PATCH 2/7] event/octeontx:
	modify octeontx eventdev test
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 19:28:37 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32184

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#39: FILE: drivers/event/octeontx/selftest_octeontx.c:55:
+#define ASSERT(cond, msg, ...) do {                                    \
+	if (!(cond)) {                                                 \
+		ssovf_log_dbg("Assert failed %s() line %d failed : "   \
+			msg , __func__, __LINE__,                      \
+			##__VA_ARGS__);                                \
+		return -1;                                             \
+	}                                                              \
+} while (0)

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#42: FILE: drivers/event/octeontx/selftest_octeontx.c:58:
+			msg , __func__, __LINE__,                      \
 			    ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#48: FILE: drivers/event/octeontx/selftest_octeontx.c:64:
+#define ASSERT_EQUAL(a, b, msg, ...) do {                              \
+	if (!(a == b)) {                                               \
+		ssovf_log_dbg("Assert failed %s() line %d failed : "   \
+			msg , __func__, __LINE__,                      \
+			##__VA_ARGS__);                                \
+		return -1;                                             \
+	}                                                              \
+} while (0)

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#51: FILE: drivers/event/octeontx/selftest_octeontx.c:67:
+			msg , __func__, __LINE__,                      \
 			    ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#57: FILE: drivers/event/octeontx/selftest_octeontx.c:73:
+#define ASSERT_SUCCESS(val, msg, ...) do {                                    \
+	typeof(val) _val = (val);                                             \
+	if (!(_val == 0)) {                                                   \
+		ssovf_log_dbg("Assert failed %s() line %d failed (err %d): "  \
+			msg , __func__, __LINE__, _val,                       \
+			##__VA_ARGS__);                                       \
+		return -1;                                                    \
+	}                                                                     \
+} while (0)

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#61: FILE: drivers/event/octeontx/selftest_octeontx.c:77:
+			msg , __func__, __LINE__, _val,                       \
 			    ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#67: FILE: drivers/event/octeontx/selftest_octeontx.c:83:
+#define ASSERT_NOT_NULL(val, msg, ...) do {                            \
+	if (!(val != NULL)) {                                          \
+		ssovf_log_dbg("Assert failed %s() line %d failed : "   \
+			msg , __func__, __LINE__,                      \
+			##__VA_ARGS__);                                \
+		return -1;                                             \
+	}                                                              \
+} while (0)

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#70: FILE: drivers/event/octeontx/selftest_octeontx.c:86:
+			msg , __func__, __LINE__,                      \
 			    ^

total: 4 errors, 4 warnings, 913 lines checked