From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw32241 [PATCH v2 4/4] net/failsafe: fix removed device handling
Date: Wed, 13 Dec 2017 17:10:39 +0100 (CET) [thread overview]
Message-ID: <20171213161039.3D2D41B00B@dpdk.org> (raw)
In-Reply-To: <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32241
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#37:
> > > In previous code this error is reported to the application contrary to
WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#109:
verified that it didnt?
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#131: FILE: drivers/net/failsafe/failsafe_private.h:318:
while (sid < tail) {
+ if (min_state > DEV_PROBED &&
ERROR:CODE_INDENT: code indent should use tabs where possible
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+ if (min_state > DEV_PROBED &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+ if (min_state > DEV_PROBED &&$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+ if (min_state > DEV_PROBED &&
[...]
+ goto next;
ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: drivers/net/failsafe/failsafe_private.h:320:
+ fs_is_removed(&sub[sid]))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: drivers/net/failsafe/failsafe_private.h:320:
+ fs_is_removed(&sub[sid]))$
ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: drivers/net/failsafe/failsafe_private.h:321:
+ goto next;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: drivers/net/failsafe/failsafe_private.h:321:
+ goto next;$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 7 warnings, 0 checks, 12 lines checked
parent reply other threads:[~2017-12-13 16:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213161039.3D2D41B00B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).