From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 3D2D41B00B; Wed, 13 Dec 2017 17:10:39 +0100 (CET)
In-Reply-To: <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com>
References: <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20171213161039.3D2D41B00B@dpdk.org>
Date: Wed, 13 Dec 2017 17:10:39 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32241 [PATCH v2 4/4] net/failsafe:
	fix removed device handling
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2017 16:10:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32241

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#37: 
> > > In previous code this error is reported to the application contrary to

WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#109: 
verified that it didnt?

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#131: FILE: drivers/net/failsafe/failsafe_private.h:318:
        while (sid < tail) {
+               if (min_state > DEV_PROBED &&

ERROR:CODE_INDENT: code indent should use tabs where possible
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+               if (min_state > DEV_PROBED &&$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+               if (min_state > DEV_PROBED &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#132: FILE: drivers/net/failsafe/failsafe_private.h:319:
+               if (min_state > DEV_PROBED &&
[...]
+                       goto next;

ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: drivers/net/failsafe/failsafe_private.h:320:
+                   fs_is_removed(&sub[sid]))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: drivers/net/failsafe/failsafe_private.h:320:
+                   fs_is_removed(&sub[sid]))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: drivers/net/failsafe/failsafe_private.h:321:
+                       goto next;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: drivers/net/failsafe/failsafe_private.h:321:
+                       goto next;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 7 warnings, 0 checks, 12 lines checked