automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Fiona Trahe <fiona.trahe@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32331 [PATCH RFC v3 1/1] lib: add compressdev API
Date: Fri, 15 Dec 2017 18:50:27 +0100 (CET)	[thread overview]
Message-ID: <20171215175027.9030D1B012@dpdk.org> (raw)
In-Reply-To: <1513360153-15036-1-git-send-email-fiona.trahe@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32331

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#292: FILE: lib/librte_compressdev/rte_comp.h:157:
+	 * ops may use history from this op */

ERROR:TRAILING_WHITESPACE: trailing whitespace
#296: FILE: lib/librte_compressdev/rte_comp.h:161:
+^I * ops will be independent of ops processed before this. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#305: FILE: lib/librte_compressdev/rte_comp.h:170:
+^I  * called rte_comp_deflate_flush_flag? And should there be $

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#306: FILE: lib/librte_compressdev/rte_comp.h:171:
+	  * comp_op_deflate_params in the op? */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: lib/librte_compressdev/rte_comp.h:183:
+    RTE_COMP_OP_STATELESS,$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#321: FILE: lib/librte_compressdev/rte_comp.h:186:
+     * flush must be set to either FLUSH_FULL or FLUSH_FINAL $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#323: FILE: lib/librte_compressdev/rte_comp.h:188:
+    RTE_COMP_OP_STATEFUL$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#327: FILE: lib/librte_compressdev/rte_comp.h:192:
+     * depending on flush_flag. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#439: FILE: lib/librte_compressdev/rte_comp.h:304:
+^Ivoid * stream_private; $

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#439: FILE: lib/librte_compressdev/rte_comp.h:304:
+	void * stream_private; 

WARNING:TABSTOP: Statements should start on a tabstop
#1176: FILE: lib/librte_compressdev/rte_compressdev.c:427:
+	    return -EINVAL;

ERROR:SPACING: space prohibited before that close parenthesis ')'
#1980: FILE: lib/librte_compressdev/rte_compressdev.h:58:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__, ) "
", \

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1981: FILE: lib/librte_compressdev/rte_compressdev.h:59:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1985: FILE: lib/librte_compressdev/rte_compressdev.h:63:
+		RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1986: FILE: lib/librte_compressdev/rte_compressdev.h:64:
+			RTE_FMT_TAIL(__VA_ARGS__,)))
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1991: FILE: lib/librte_compressdev/rte_compressdev.h:69:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1992: FILE: lib/librte_compressdev/rte_compressdev.h:70:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1996: FILE: lib/librte_compressdev/rte_compressdev.h:74:
+		RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1997: FILE: lib/librte_compressdev/rte_compressdev.h:75:
+			dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                       ^

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2666: FILE: lib/librte_compressdev/rte_compressdev.h:744:
+ * so this only needs to be called for one device per driver-type. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2667: FILE: lib/librte_compressdev/rte_compressdev.h:745:
+ * All private data stored must be shareable across devices, so read-only.  $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2669: FILE: lib/librte_compressdev/rte_compressdev.h:747:
+ * must used the same xform for each init. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2765: FILE: lib/librte_compressdev/rte_compressdev.h:843:
+ *^I^I^I^Iwill be stored. $

ERROR:POINTER_LOCATION: "foo ** bar" should be "foo **bar"
#2775: FILE: lib/librte_compressdev/rte_compressdev.h:853:
+					void ** stream);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2782: FILE: lib/librte_compressdev/rte_compressdev.h:860:
+ * @param^Istream^I^Iptr to PMD's private stream data $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2783: FILE: lib/librte_compressdev/rte_compressdev.h:861:
+ * $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2784: FILE: lib/librte_compressdev/rte_compressdev.h:862:
+ * $

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#2788: FILE: lib/librte_compressdev/rte_compressdev.h:866:
+rte_comp_stream_free(uint8_t dev_id, void * stream);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3609: FILE: lib/librte_compressdev/rte_compressdev_version.map:50:
+^I$

total: 24 errors, 5 warnings, 3534 lines checked

           reply	other threads:[~2017-12-15 17:50 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1513360153-15036-1-git-send-email-fiona.trahe@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215175027.9030D1B012@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).