From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 693CC2C2B; Sun, 17 Dec 2017 13:23:30 +0100 (CET) In-Reply-To: <1513513315-21618-3-git-send-email-ophirmu@mellanox.com> References: <1513513315-21618-3-git-send-email-ophirmu@mellanox.com> To: test-report@dpdk.org Cc: Ophir Munk Message-Id: <20171217122330.693CC2C2B@dpdk.org> Date: Sun, 17 Dec 2017 13:23:30 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw32341 [PATCH v1 2/3] net/tap: add eBPF instructions X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Dec 2017 12:23:30 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/32341 _coding style issues_ WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(cls_q_insns) #172: FILE: drivers/net/tap/tap_bpf_insns.c:119: + (sizeof(cls_q_insns) / sizeof(cls_q_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tailing_insns) #217: FILE: drivers/net/tap/tap_bpf_insns.c:164: + (sizeof(tailing_insns) / sizeof(tailing_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(hash_appending_insns) #263: FILE: drivers/net/tap/tap_bpf_insns.c:210: + (sizeof(hash_appending_insns) / sizeof(hash_appending_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(queue_setting_insns) #335: FILE: drivers/net/tap/tap_bpf_insns.c:282: + (sizeof(queue_setting_insns) / sizeof(queue_setting_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l2_src_hash_insns) #956: FILE: drivers/net/tap/tap_bpf_insns.c:903: + (sizeof(l2_src_hash_insns) / sizeof(l2_src_hash_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l2_dst_hash_insns) #1563: FILE: drivers/net/tap/tap_bpf_insns.c:1510: + (sizeof(l2_dst_hash_insns) / sizeof(l2_dst_hash_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l3_dst_hash_insns) #3323: FILE: drivers/net/tap/tap_bpf_insns.c:3270: + (sizeof(l3_dst_hash_insns) / sizeof(l3_dst_hash_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l3_src_hash_insns) #5072: FILE: drivers/net/tap/tap_bpf_insns.c:5019: + (sizeof(l3_src_hash_insns) / sizeof(l3_src_hash_insns[0])) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l4_src_hash_insns) #5414: FILE: drivers/net/tap/tap_bpf_insns.c:5361: + (sizeof(l4_src_hash_insns) / sizeof(l4_src_hash_insns[0])) CHECK:ARCH_DEFINES: architecture specific defines should be avoided #5436: FILE: drivers/net/tap/tap_bpf_insns.c:5383: +# if defined(__i386__) WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5619: FILE: drivers/net/tap/tap_bpf_program.c:133: + printt("hash(): rss key is not configured "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5641: FILE: drivers/net/tap/tap_bpf_program.c:155: + printt("hash(%d): hash = %x (off = %d) ", WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5654: FILE: drivers/net/tap/tap_bpf_program.c:168: + printt("hash(%d): hash = %x (off = %d) ", WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5677: FILE: drivers/net/tap/tap_bpf_program.c:191: + printt("hash(%d): hash = %x (off = %d) ", WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5692: FILE: drivers/net/tap/tap_bpf_program.c:206: + printt("hash(%d): hash = %x (off = %d) ", WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5716: FILE: drivers/net/tap/tap_bpf_program.c:230: + printt("hash(%d): hash = %x (off = %d) ", WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5731: FILE: drivers/net/tap/tap_bpf_program.c:245: + printt("hash(%d): hash = %x (off = %d) ", CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'f == HASH_FIELD_L4_SRC' #5745: FILE: drivers/net/tap/tap_bpf_program.c:259: + if ((ip_proto == IPPROTO_TCP || ip_proto == IPPROTO_UDP) && + (rsskey->hash_fields & (1 << HASH_FIELD_L4_SRC)) && + (f == HASH_FIELD_L4_SRC)) { WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string #5754: FILE: drivers/net/tap/tap_bpf_program.c:268: + printt("hash(%d): hash = %x (off = %d) ", total: 0 errors, 17 warnings, 2 checks, 5824 lines checked