From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 1643A1B013; Tue, 19 Dec 2017 07:40:47 +0100 (CET)
In-Reply-To: <20171219063840.18981-11-stephen@networkplumber.org>
References: <20171219063840.18981-11-stephen@networkplumber.org>
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20171219064047.1643A1B013@dpdk.org>
Date: Tue, 19 Dec 2017 07:40:47 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32399 [PATCH 10/11] qede: implement
	dynamic logging
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 06:40:47 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32399

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#83: FILE: drivers/net/qede/qede_logs.h:14:
+#define DP_ERR(p_dev, fmt, ...)				\
+	rte_log(RTE_LOG_ERR, qede_logtype_driver,	\
+		"[%s:%d(%s)]" fmt,			\
+		__func__, __LINE__,			\
+		(p_dev)->name ? (p_dev)->name : "",	\
 		##__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#131: FILE: drivers/net/qede/qede_logs.h:48:
+#define DP_VERBOSE(p_dev, module, fmt, ...)				\
+	do {								\
+		if ((p_dev)->dp_module & module)			\
+			rte_log(RTE_LOG_DEBUG, qede_logtype_driver,	\
+				"[%s:%d(%s)]" fmt,			\
+				__func__, __LINE__,			\
+				(p_dev)->name ? (p_dev)->name : "",	\
+				##__VA_ARGS__);				\
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 117 lines checked