From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 217E31B232; Tue, 19 Dec 2017 12:06:21 +0100 (CET)
In-Reply-To: <ac6a76546782694fb41b0de3dfcf6ef23de71541.1513680516.git.anatoly.burakov@intel.com>
References: <ac6a76546782694fb41b0de3dfcf6ef23de71541.1513680516.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20171219110621.217E31B232@dpdk.org>
Date: Tue, 19 Dec 2017 12:06:21 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32421 [PATCH 10/23] eal: read
	hugepage counts from node-specific sysfs path
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 11:06:21 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32421

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#49: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:103:
+static uint32_t
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#50: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:104:
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {

WARNING:MISORDERED_TYPE: type 'long unsigned' should be specified in [[un]signed] [short|int|long|long long] order
#53: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:107:
+	long unsigned num_pages = 0;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#78: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:132:
+	 * anyway ... */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#93: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:317:
+	unsigned i, total_pages, num_sizes = 0;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#106: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:373:
+		 * in one socket and sorting them later */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#111: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:378:
+				unsigned num_pages =

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#118: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:385:
+		 * back to old way */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#119: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:386:
+		if (total_pages == 0) {
+			hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#132: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:414:
+		unsigned j, num_pages = 0;

total: 1 errors, 9 warnings, 105 lines checked