From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32425 [PATCH RFC 10/23] eal: populate hugepage counts from socket-specific sysfs path
Date: Tue, 19 Dec 2017 12:06:24 +0100 (CET) [thread overview]
Message-ID: <20171219110624.C4FE81B2EB@dpdk.org> (raw)
In-Reply-To: <3326c920b0e7fffb150179c02013b2a50e3348f5.1513594170.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32425
_coding style issues_
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#49: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:103:
+static uint32_t
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#50: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:104:
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {
WARNING:MISORDERED_TYPE: type 'long unsigned' should be specified in [[un]signed] [short|int|long|long long] order
#53: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:107:
+ long unsigned num_pages = 0;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#78: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:132:
+ * anyway ... */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#93: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:317:
+ unsigned i, total_pages, num_sizes = 0;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#106: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:373:
+ * in one socket and sorting them later */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#111: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:378:
+ unsigned num_pages =
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#118: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:385:
+ * back to old way */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#119: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:386:
+ if (total_pages == 0) {
+ hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
+ }
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#132: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:414:
+ unsigned j, num_pages = 0;
total: 1 errors, 9 warnings, 105 lines checked
parent reply other threads:[~2017-12-19 11:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <3326c920b0e7fffb150179c02013b2a50e3348f5.1513594170.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219110624.C4FE81B2EB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).