From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32432 [PATCH 12/23] eal: add support for dynamic memory allocation
Date: Tue, 19 Dec 2017 12:09:54 +0100 (CET) [thread overview]
Message-ID: <20171219110954.96A7A1B017@dpdk.org> (raw)
In-Reply-To: <5db1054689acb30ec0139f06dd2c43845dea68cd.1513680516.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32432
_coding style issues_
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#31: FILE: lib/librte_eal/common/eal_memalloc.h
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#104: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#221: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:113:
+static bool
+prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#248: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:140:
+static void
+resotre_numa(int *oldpolicy, struct bitmask *oldmask) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#264: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:156:
+static int
+alloc_page(struct rte_memseg *ms, void *addr, uint64_t size, int socket_id,
+ struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#266: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:158:
+ struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#266: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:158:
+ struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) {
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#303: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:195:
+ * the kernel fills this segment with zeros */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#343: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:235:
+ (unsigned)(size / 0x100000));
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#378: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:270:
+int
+eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n,
+ uint64_t size, int socket, bool exact) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#384: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:276:
+ unsigned msl_idx;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#414: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:306:
+ if (cur_msl->hugepage_sz != size) {
+ continue;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#417: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:309:
+ if (cur_msl->socket_id != socket) {
+ continue;
+ }
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#499: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:391:
+ memset(ms, 0, sizeof(struct rte_memseg*) * n);
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#518: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:410:
+struct rte_memseg *
+eal_memalloc_alloc_page(uint64_t size, int socket) {
total: 8 errors, 7 warnings, 477 lines checked
parent reply other threads:[~2017-12-19 11:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5db1054689acb30ec0139f06dd2c43845dea68cd.1513680516.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219110954.96A7A1B017@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).