From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32460 [PATCH RFC v2 14/23] eal: add support for dynamic unmapping of pages
Date: Tue, 19 Dec 2017 12:15:28 +0100 (CET) [thread overview]
Message-ID: <20171219111528.19DE31B212@dpdk.org> (raw)
In-Reply-To: <bc77dcd45d3d4ca301fc4753bec25e5db93e94ec.1513681966.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32460
_coding style issues_
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#66: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:282:
+static int
+free_page(struct rte_memseg *ms, struct hugepage_info *hi, unsigned list_idx,
+ unsigned seg_idx) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#67: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:283:
+free_page(struct rte_memseg *ms, struct hugepage_info *hi, unsigned list_idx,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#68: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:284:
+ unsigned seg_idx) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#108: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:324:
+ if (is_zero_length(fd)) {
+ unlink(path);
+ }
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#167: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:500:
+int
+eal_memalloc_free_page(struct rte_memseg *ms) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#171: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:504:
+ unsigned msl_idx, seg_idx;
total: 2 errors, 4 warnings, 171 lines checked
parent reply other threads:[~2017-12-19 11:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <bc77dcd45d3d4ca301fc4753bec25e5db93e94ec.1513681966.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219111528.19DE31B212@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).