From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 19DE31B212; Tue, 19 Dec 2017 12:15:28 +0100 (CET)
In-Reply-To: <bc77dcd45d3d4ca301fc4753bec25e5db93e94ec.1513681966.git.anatoly.burakov@intel.com>
References: <bc77dcd45d3d4ca301fc4753bec25e5db93e94ec.1513681966.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20171219111528.19DE31B212@dpdk.org>
Date: Tue, 19 Dec 2017 12:15:28 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32460 [PATCH RFC v2 14/23] eal: add
	support for dynamic unmapping of pages
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 11:15:28 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32460

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#66: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:282:
+static int
+free_page(struct rte_memseg *ms, struct hugepage_info *hi, unsigned list_idx,
+		unsigned seg_idx) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#67: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:283:
+free_page(struct rte_memseg *ms, struct hugepage_info *hi, unsigned list_idx,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#68: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:284:
+		unsigned seg_idx) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#108: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:324:
+		if (is_zero_length(fd)) {
+			unlink(path);
+		}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#167: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:500:
+int
+eal_memalloc_free_page(struct rte_memseg *ms) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#171: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:504:
+	unsigned msl_idx, seg_idx;

total: 2 errors, 4 warnings, 171 lines checked