From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 4BFBC1B220; Tue, 19 Dec 2017 12:15:30 +0100 (CET) In-Reply-To: <5db1054689acb30ec0139f06dd2c43845dea68cd.1513681966.git.anatoly.burakov@intel.com> References: <5db1054689acb30ec0139f06dd2c43845dea68cd.1513681966.git.anatoly.burakov@intel.com> To: test-report@dpdk.org Cc: Anatoly Burakov Message-Id: <20171219111530.4BFBC1B220@dpdk.org> Date: Tue, 19 Dec 2017 12:15:30 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw32461 [PATCH RFC v2 12/23] eal: add support for dynamic memory allocation X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 11:15:30 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/32461 _coding style issues_ ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #32: FILE: lib/librte_eal/common/eal_memalloc.h ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #105: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #222: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:113: +static bool +prepare_numa(int *oldpolicy, struct bitmask *oldmask, int socket_id) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #249: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:140: +static void +resotre_numa(int *oldpolicy, struct bitmask *oldmask) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #265: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:156: +static int +alloc_page(struct rte_memseg *ms, void *addr, uint64_t size, int socket_id, + struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #267: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:158: + struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #267: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:158: + struct hugepage_info *hi, unsigned list_idx, unsigned seg_idx) { WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #304: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:195: + * the kernel fills this segment with zeros */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #344: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:235: + (unsigned)(size / 0x100000)); ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #379: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:270: +int +eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, + uint64_t size, int socket, bool exact) { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #385: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:276: + unsigned msl_idx; WARNING:BRACES: braces {} are not necessary for single statement blocks #415: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:306: + if (cur_msl->hugepage_sz != size) { + continue; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #418: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:309: + if (cur_msl->socket_id != socket) { + continue; + } ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #500: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:391: + memset(ms, 0, sizeof(struct rte_memseg*) * n); ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #519: FILE: lib/librte_eal/linuxapp/eal/eal_memalloc.c:410: +struct rte_memseg * +eal_memalloc_alloc_page(uint64_t size, int socket) { total: 8 errors, 7 warnings, 477 lines checked