From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 1E8EA1B228; Tue, 19 Dec 2017 12:15:33 +0100 (CET) In-Reply-To: References: To: test-report@dpdk.org Cc: Anatoly Burakov Message-Id: <20171219111533.1E8EA1B228@dpdk.org> Date: Tue, 19 Dec 2017 12:15:33 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw32462 [PATCH RFC v2 03/23] eal: add rte_fbarray X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 11:15:33 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/32462 _coding style issues_ ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #82: FILE: lib/librte_eal/common/eal_common_fbarray.c ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #150: FILE: lib/librte_eal/common/eal_common_fbarray.c:64: +static size_t +calc_mask_size(int len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #155: FILE: lib/librte_eal/common/eal_common_fbarray.c:69: +static size_t +calc_data_size(size_t page_sz, int elt_sz, int len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #162: FILE: lib/librte_eal/common/eal_common_fbarray.c:76: +static struct used_mask * +get_used_mask(void *data, int elt_sz, int len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #167: FILE: lib/librte_eal/common/eal_common_fbarray.c:81: +static void +move_mask(void *data, int elt_sz, int old_len, int new_len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #180: FILE: lib/librte_eal/common/eal_common_fbarray.c:94: +static int +expand_and_map(void *addr, const char *name, size_t old_len, size_t new_len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #216: FILE: lib/librte_eal/common/eal_common_fbarray.c:130: +static int +find_next_n(const struct used_mask *msk, int start, int n, bool used) { WARNING:BRACES: braces {} are not necessary for single statement blocks #272: FILE: lib/librte_eal/common/eal_common_fbarray.c:186: + for (s_idx = 0; s_idx < n - 1; s_idx++) { + tmp_msk &= tmp_msk >> 1ULL; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #327: FILE: lib/librte_eal/common/eal_common_fbarray.c:241: + if (!found) { + continue; + } ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #336: FILE: lib/librte_eal/common/eal_common_fbarray.c:250: +static int +find_next(const struct used_mask *msk, int start, bool used) { WARNING:BRACES: braces {} are not necessary for single statement blocks #355: FILE: lib/librte_eal/common/eal_common_fbarray.c:269: + if (!used) { + cur = ~cur; + } ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #377: FILE: lib/librte_eal/common/eal_common_fbarray.c:291: +static int +find_contig(const struct used_mask *msk, int start, bool used) { WARNING:BRACES: braces {} are not necessary for single statement blocks #390: FILE: lib/librte_eal/common/eal_common_fbarray.c:304: + if (!used) { + cur = ~cur; + } ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #422: FILE: lib/librte_eal/common/eal_common_fbarray.c:336: +int +rte_fbarray_alloc(struct rte_fbarray *arr, const char *name, int cur_len, + int max_len, int elt_sz) { WARNING:BRACES: braces {} are not necessary for single statement blocks #448: FILE: lib/librte_eal/common/eal_common_fbarray.c:362: + if (expand_and_map(data, name, 0, cur_mmap_len)) { + return -1; + } ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #466: FILE: lib/librte_eal/common/eal_common_fbarray.c:380: +int +rte_fbarray_attach(const struct rte_fbarray *arr) { WARNING:BRACES: braces {} are not necessary for single statement blocks #480: FILE: lib/librte_eal/common/eal_common_fbarray.c:394: + if (expand_and_map(data, arr->name, 0, cur_mmap_len)) { + return -1; + } ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #487: FILE: lib/librte_eal/common/eal_common_fbarray.c:401: +void +rte_fbarray_free(struct rte_fbarray *arr) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #494: FILE: lib/librte_eal/common/eal_common_fbarray.c:408: +int +rte_fbarray_resize(struct rte_fbarray *arr, int new_len) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #524: FILE: lib/librte_eal/common/eal_common_fbarray.c:438: +void * +rte_fbarray_get(const struct rte_fbarray *arr, int idx) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #532: FILE: lib/librte_eal/common/eal_common_fbarray.c:446: +int +rte_fbarray_set_used(struct rte_fbarray *arr, int idx, bool used) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #558: FILE: lib/librte_eal/common/eal_common_fbarray.c:472: +int +rte_fbarray_is_used(const struct rte_fbarray *arr, int idx) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #570: FILE: lib/librte_eal/common/eal_common_fbarray.c:484: +int +rte_fbarray_find_next_free(const struct rte_fbarray *arr, int start) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #582: FILE: lib/librte_eal/common/eal_common_fbarray.c:496: +int +rte_fbarray_find_next_used(const struct rte_fbarray *arr, int start) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #594: FILE: lib/librte_eal/common/eal_common_fbarray.c:508: +int +rte_fbarray_find_next_n_free(const struct rte_fbarray *arr, int start, int n) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #606: FILE: lib/librte_eal/common/eal_common_fbarray.c:520: +int +rte_fbarray_find_next_n_used(const struct rte_fbarray *arr, int start, int n) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #618: FILE: lib/librte_eal/common/eal_common_fbarray.c:532: +int +rte_fbarray_find_contig_free(const struct rte_fbarray *arr, int start) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #633: FILE: lib/librte_eal/common/eal_common_fbarray.c:547: +int +rte_fbarray_find_contig_used(const struct rte_fbarray *arr, int start) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #645: FILE: lib/librte_eal/common/eal_common_fbarray.c:559: +int +rte_fbarray_find_idx(const struct rte_fbarray *arr, const void *elt) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #656: FILE: lib/librte_eal/common/eal_common_fbarray.c:570: +void +rte_fbarray_dump_metadata(const struct rte_fbarray *arr, FILE *f) { WARNING:BRACES: braces {} are not necessary for single statement blocks #668: FILE: lib/librte_eal/common/eal_common_fbarray.c:582: + for (int i = 0; i < msk->n_masks; i++) { + fprintf(f, "msk idx %i: 0x%016lx ", i, msk->data[i]); + } ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #704: FILE: lib/librte_eal/common/include/rte_fbarray.h total: 25 errors, 7 warnings, 723 lines checked