From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B81F11B1DF; Tue, 19 Dec 2017 12:15:43 +0100 (CET)
In-Reply-To: <c9a798795633a8e4a4bf32f1a57c25bb5ce099fd.1513681966.git.anatoly.burakov@intel.com>
References: <c9a798795633a8e4a4bf32f1a57c25bb5ce099fd.1513681966.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20171219111543.B81F11B1DF@dpdk.org>
Date: Tue, 19 Dec 2017 12:15:43 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32469 [PATCH RFC v2 16/23] eal:
	enable dynamic memory allocation/free on malloc/free
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 11:15:43 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32469

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#148: FILE: lib/librte_eal/common/malloc_elem.c:427:
+void
+malloc_elem_hide_region(struct malloc_elem *elem, void *start, size_t len) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#288: FILE: lib/librte_eal/common/malloc_heap.c:158:
+		unsigned flags, size_t align, size_t bound)

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#309: FILE: lib/librte_eal/common/malloc_heap.c:176:
+static void *
+try_expand_heap(struct malloc_heap *heap, struct rte_memseg_list *msl,
+		const char *type, size_t size, int socket, unsigned flags,
+		size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#311: FILE: lib/librte_eal/common/malloc_heap.c:178:
+		const char *type, size_t size, int socket, unsigned flags,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#362: FILE: lib/librte_eal/common/malloc_heap.c:229:
+	for (i = 0; i < n_pages; i++) {
+		eal_memalloc_free_page(ms[i]);
+	}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#370: FILE: lib/librte_eal/common/malloc_heap.c:237:
+static int
+compare_pagesz(const void *a, const void *b) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#383: FILE: lib/librte_eal/common/malloc_heap.c:250:
+static void *
+heap_alloc_on_socket(const char *type, size_t size, int socket,
+		unsigned flags, size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#385: FILE: lib/librte_eal/common/malloc_heap.c:252:
+		unsigned flags, size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#392: FILE: lib/librte_eal/common/malloc_heap.c:259:
+	unsigned size_flags = flags & ~RTE_MEMZONE_SIZE_HINT_ONLY;

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#483: FILE: lib/librte_eal/common/malloc_heap.c:350:
+void *
+malloc_heap_alloc(const char *type, size_t size, int socket_arg, unsigned flags,
+		size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#484: FILE: lib/librte_eal/common/malloc_heap.c:351:
+malloc_heap_alloc(const char *type, size_t size, int socket_arg, unsigned flags,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#571: FILE: lib/librte_eal/common/malloc_heap.c:435:
+	malloc_elem_hide_region(elem, (void*) aligned_start, aligned_len);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#603: FILE: lib/librte_eal/common/malloc_heap.h:56:
+malloc_heap_alloc(const char *type, size_t size, int socket, unsigned flags,

total: 6 errors, 7 warnings, 559 lines checked