* [dpdk-test-report] |WARNING| pw32621 [PATCH 1/5] lib: add Port Representor library
[not found] <20171222144121.10041-2-remy.horton@intel.com>
@ 2017-12-22 14:42 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-12-22 14:42 UTC (permalink / raw)
To: test-report; +Cc: Remy Horton
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32621
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#137: FILE: lib/librte_representor/rte_port_representor.c:24:
+#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed, ret= %d", (retval)); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#144: FILE: lib/librte_representor/rte_port_representor.c:31:
+#define RTE_VERIFY_OR_RET(val) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed"); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#213: FILE: lib/librte_representor/rte_port_representor.c:100:
+#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \
+ if (!strstr(ethdev->data->name, RTE_PORT_REPRESENTOR_DEVICE_NAME)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#221: FILE: lib/librte_representor/rte_port_representor.c:108:
+#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \
+ if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \
+ RTE_PMD_DEBUG_TRACE("Vport is not a representor port"); \
+ return retval; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 582 lines checked
^ permalink raw reply [flat|nested] only message in thread