automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32652 [PATCH] member: fix memory leak on error
Date: Fri, 22 Dec 2017 19:33:43 +0100 (CET)	[thread overview]
Message-ID: <20171222183343.104931B625@dpdk.org> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A6445B26CC@ORSMSX105.amr.corp.intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32652

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
I realize that rte_member_free does not do anything good here. As a fix, I think the following should work. Is there any other concern?

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#33: 
--- a/lib/librte_member/rte_member.c

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#36: FILE: lib/librte_member/rte_member.c:191:


ERROR:DOS_LINE_ENDINGS: DOS line endings
#40: FILE: lib/librte_member/rte_member.c:194:
+       rte_free(te);^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: lib/librte_member/rte_member.c:194:
+       rte_free(te);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#41: FILE: lib/librte_member/rte_member.c:195:
+       rte_free(setsum);^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#41: FILE: lib/librte_member/rte_member.c:195:
+       rte_free(setsum);^M$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 5 errors, 3 warnings, 9 lines checked

           reply	other threads:[~2017-12-22 18:33 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <D2C4A16CA39F7F4E8E384D204491D7A6445B26CC@ORSMSX105.amr.corp.intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222183343.104931B625@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).