automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Subject: [dpdk-test-report] |WARNING| pw32653 [PATCH v4 1/5] bbdev: introducing wireless base band device (BBDEV) abstraction
Date: Sat, 23 Dec 2017 01:52:36 +0100 (CET)	[thread overview]
Message-ID: <20171223005236.3B7EB1B64D@dpdk.org> (raw)
In-Reply-To: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32653

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#59: FILE: MAINTAINERS:276:
+M: Amr Mokhtar <amr.mokhtar@intel.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#60: FILE: MAINTAINERS:277:
+F: lib/librte_bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#61: FILE: MAINTAINERS:278:
+F: doc/guides/prog_guide/bbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#825: FILE: lib/librte_bbdev/rte_bbdev.c:31:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+	if (dev == NULL) { \
+		rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#833: FILE: lib/librte_bbdev/rte_bbdev.c:39:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+	if (dev->dev_ops == NULL) { \
+		rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+				dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#842: FILE: lib/librte_bbdev/rte_bbdev.c:48:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+	if (func == NULL) { \
+		rte_bbdev_log(ERR, "device %u does not support %s", \
+				dev_id, #func); \
+		return -ENOTSUP; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#851: FILE: lib/librte_bbdev/rte_bbdev.c:57:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+	if (queue_id >= dev->data->num_queues) { \
+		rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+				queue_id, dev->data->dev_id); \
+		return -ERANGE; \
+	} \
+} while (0)

total: 0 errors, 7 warnings, 3397 lines checked

           reply	other threads:[~2017-12-23  0:52 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171223005236.3B7EB1B64D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=amr.mokhtar@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).