From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 3B7EB1B64D; Sat, 23 Dec 2017 01:52:36 +0100 (CET)
In-Reply-To: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com>
References: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com>
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Message-Id: <20171223005236.3B7EB1B64D@dpdk.org>
Date: Sat, 23 Dec 2017 01:52:36 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32653 [PATCH v4 1/5] bbdev:
	introducing wireless base band device (BBDEV) abstraction
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Dec 2017 00:52:36 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32653

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#59: FILE: MAINTAINERS:276:
+M: Amr Mokhtar <amr.mokhtar@intel.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#60: FILE: MAINTAINERS:277:
+F: lib/librte_bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#61: FILE: MAINTAINERS:278:
+F: doc/guides/prog_guide/bbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#825: FILE: lib/librte_bbdev/rte_bbdev.c:31:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+	if (dev == NULL) { \
+		rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#833: FILE: lib/librte_bbdev/rte_bbdev.c:39:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+	if (dev->dev_ops == NULL) { \
+		rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+				dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#842: FILE: lib/librte_bbdev/rte_bbdev.c:48:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+	if (func == NULL) { \
+		rte_bbdev_log(ERR, "device %u does not support %s", \
+				dev_id, #func); \
+		return -ENOTSUP; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#851: FILE: lib/librte_bbdev/rte_bbdev.c:57:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+	if (queue_id >= dev->data->num_queues) { \
+		rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+				queue_id, dev->data->dev_id); \
+		return -ERANGE; \
+	} \
+} while (0)

total: 0 errors, 7 warnings, 3397 lines checked