From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EC40A1B681; Sun, 24 Dec 2017 11:48:38 +0100 (CET)
In-Reply-To: <1514112404-13398-7-git-send-email-arybchenko@solarflare.com>
References: <1514112404-13398-7-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20171224104838.EC40A1B681@dpdk.org>
Date: Sun, 24 Dec 2017 11:48:38 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32664 [PATCH 06/14] net/sfc/base:
	add function to create packed stream RxQ
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 10:48:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32664

_coding style issues_


WARNING:TYPO_SPELLING: 'paramters' may be misspelled - perhaps 'parameters'?
#19: 
applicable paramters.

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ps_buf_size != MC_CMD_INIT_RXQ_EXT_IN_PS_BUFF_1M'
#128: FILE: drivers/net/sfc/base/ef10_rx.c:1024:
+		if ((ps_buf_size != MC_CMD_INIT_RXQ_EXT_IN_PS_BUFF_1M) &&
 		    (encp->enc_rx_var_packed_stream_supported == B_FALSE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_rx_var_packed_stream_supported == B_FALSE'
#128: FILE: drivers/net/sfc/base/ef10_rx.c:1024:
+		if ((ps_buf_size != MC_CMD_INIT_RXQ_EXT_IN_PS_BUFF_1M) &&
 		    (encp->enc_rx_var_packed_stream_supported == B_FALSE)) {

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#197: FILE: drivers/net/sfc/base/efx.h:2037:
+extern	__checkReturn	efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#260: FILE: drivers/net/sfc/base/efx_rx.c:650:
+	if ((rc = erxop->erxo_qcreate(enp, index, label, type, type_data, esmp,

total: 1 errors, 1 warnings, 3 checks, 252 lines checked