From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 8AC811B6CE; Sun, 24 Dec 2017 11:48:44 +0100 (CET) In-Reply-To: <1514112404-13398-9-git-send-email-arybchenko@solarflare.com> References: <1514112404-13398-9-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20171224104844.8AC811B6CE@dpdk.org> Date: Sun, 24 Dec 2017 11:48:44 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw32670 [PATCH 08/14] net/sfc/base: add API to control UDP tunnel ports X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Dec 2017 10:48:44 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/32670 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #96: FILE: drivers/net/sfc/base/efx.h:2643: +extern __checkReturn efx_rc_t WARNING:TYPO_SPELLING: 'managment' may be misspelled - perhaps 'management'? #130: FILE: drivers/net/sfc/base/efx.h:2677: + * EAGAIN is returned if hardware will be reset (datapath and managment CPU CHECK:SPACING: No space is necessary after a cast #315: FILE: drivers/net/sfc/base/efx_tunnel.c:79: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #315: FILE: drivers/net/sfc/base/efx_tunnel.c:79: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #352: FILE: drivers/net/sfc/base/efx_tunnel.c:116: + EFX_STATIC_ASSERT(sizeof (efx_dword_t) == ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #380: FILE: drivers/net/sfc/base/efx_tunnel.c:144: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #391: FILE: drivers/net/sfc/base/efx_tunnel.c:155: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #434: FILE: drivers/net/sfc/base/efx_tunnel.c:198: + memset(etcp->etc_udp_entries, 0, sizeof (etcp->etc_udp_entries)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #440: FILE: drivers/net/sfc/base/efx_tunnel.c:204: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #448: FILE: drivers/net/sfc/base/efx_tunnel.c:212: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_etop->eto_udp_encap_supported != NULL' #461: FILE: drivers/net/sfc/base/efx_tunnel.c:225: + if ((enp->en_etop->eto_udp_encap_supported != NULL) && + enp->en_etop->eto_udp_encap_supported(enp)) { CHECK:SPACING: No space is necessary after a cast #468: FILE: drivers/net/sfc/base/efx_tunnel.c:232: + (void) efx_mcdi_set_tunnel_encap_udp_ports(enp, NULL, B_TRUE, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #489: FILE: drivers/net/sfc/base/efx_tunnel.c:253: + return (0); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT) #493: FILE: drivers/net/sfc/base/efx_tunnel.c:257: + return (ENOENT); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #543: FILE: drivers/net/sfc/base/efx_tunnel.c:307: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #558: FILE: drivers/net/sfc/base/efx_tunnel.c:322: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #592: FILE: drivers/net/sfc/base/efx_tunnel.c:356: + sizeof (etcp->etc_udp_entries[0])); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #596: FILE: drivers/net/sfc/base/efx_tunnel.c:360: + sizeof (etcp->etc_udp_entries[0])); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #600: FILE: drivers/net/sfc/base/efx_tunnel.c:364: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #609: FILE: drivers/net/sfc/base/efx_tunnel.c:373: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #624: FILE: drivers/net/sfc/base/efx_tunnel.c:388: + memset(etcp->etc_udp_entries, 0, sizeof (etcp->etc_udp_entries)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #643: FILE: drivers/net/sfc/base/efx_tunnel.c:407: + if ((rc = enp->en_etop->eto_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #646: FILE: drivers/net/sfc/base/efx_tunnel.c:410: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #654: FILE: drivers/net/sfc/base/efx_tunnel.c:418: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #683: FILE: drivers/net/sfc/base/efx_tunnel.c:447: + memcpy(&etc, etcp, sizeof (etc)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #719: FILE: drivers/net/sfc/base/efx_tunnel.c:483: + return (rc); total: 13 errors, 9 warnings, 4 checks, 658 lines checked