From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-test-report] |WARNING| pw32677 [PATCH v3 01/11] eal: add common test assert macros
Date: Mon, 25 Dec 2017 20:19:24 +0100 (CET) [thread overview]
Message-ID: <20171225191924.CA4981B3DC@dpdk.org> (raw)
In-Reply-To: <20171225191738.17151-1-pbhagavatula@caviumnetworks.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32677
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#94: FILE: lib/librte_eal/common/include/rte_test.h:38:
+#define RTE_TEST_ASSERT(cond, msg, ...) do { \
+ if (!(cond)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#102: FILE: lib/librte_eal/common/include/rte_test.h:46:
+#define RTE_TEST_ASSERT_EQUAL(a, b, msg, ...) do { \
+ if (!(a == b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: lib/librte_eal/common/include/rte_test.h:54:
+#define RTE_TEST_ASSERT_NOT_EQUAL(a, b, msg, ...) do { \
+ if (!(a != b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#118: FILE: lib/librte_eal/common/include/rte_test.h:62:
+#define RTE_TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+ typeof(val) _val = (val); \
+ if (!(_val == 0)) { \
+ RTE_LOG(DEBUG, EAL, \
+ "Test assert %s line %d failed (err %d): " \
+ msg "
", __func__, __LINE__, _val, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#129: FILE: lib/librte_eal/common/include/rte_test.h:73:
+#define RTE_TEST_ASSERT_FAIL(val, msg, ...) do { \
+ if (!(val != 0)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#137: FILE: lib/librte_eal/common/include/rte_test.h:81:
+#define RTE_TEST_ASSERT_NULL(val, msg, ...) do { \
+ if (!(val == NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#145: FILE: lib/librte_eal/common/include/rte_test.h:89:
+#define RTE_TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+ if (!(val != NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
total: 0 errors, 7 warnings, 105 lines checked
parent reply other threads:[~2017-12-25 19:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171225191738.17151-1-pbhagavatula@caviumnetworks.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171225191924.CA4981B3DC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).