From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BCB7A4CE4; Fri, 29 Dec 2017 10:30:16 +0100 (CET)
In-Reply-To: <1514570702-154906-5-git-send-email-xiao.w.wang@intel.com>
References: <1514570702-154906-5-git-send-email-xiao.w.wang@intel.com>
To: test-report@dpdk.org
Cc: Xiao Wang <xiao.w.wang@intel.com>
Message-Id: <20171229093016.BCB7A4CE4@dpdk.org>
Date: Fri, 29 Dec 2017 10:30:16 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32795 [PATCH RFC 4/4] examples/vdpa:
	add virtio-net PCI device driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 09:30:16 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32795

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#647: FILE: examples/vdpa/vdpa_virtio_net.c:146:
+int pci_get_kernel_driver_by_path(const char *filename, char *dri_name);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#648: FILE: examples/vdpa/vdpa_virtio_net.c:147:
+int pci_parse_sysfs_resource(const char *filename, struct rte_pci_device *dev);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#650: FILE: examples/vdpa/vdpa_virtio_net.c:149:
+int vfio_get_container_fd(void);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#651: FILE: examples/vdpa/vdpa_virtio_net.c:150:
+int vfio_get_group_fd(int iommu_group_no);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#652: FILE: examples/vdpa/vdpa_virtio_net.c:151:
+int vfio_get_group_no(const char *sysfs_base,

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#655: FILE: examples/vdpa/vdpa_virtio_net.c:154:
+int pci_vfio_get_msix_bar(int fd, struct pci_msix_table *msix_table);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#656: FILE: examples/vdpa/vdpa_virtio_net.c:155:
+int pci_vfio_setup_interrupts(struct rte_pci_device *dev, int vfio_dev_fd);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#657: FILE: examples/vdpa/vdpa_virtio_net.c:156:
+int pci_vfio_set_bus_master(int dev_fd, bool op);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#659: FILE: examples/vdpa/vdpa_virtio_net.c:158:
+extern void *pci_map_addr;

total: 0 errors, 9 warnings, 1798 lines checked