From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw32816 [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time
Date: Sun, 31 Dec 2017 08:53:52 +0100 (CET) [thread overview]
Message-ID: <20171231075352.50EC72C08@dpdk.org> (raw)
In-Reply-To: <d17b90a4d765004f878e846b1bde1da6e954306f.1514706323.git.shacharbe@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32816
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxB)
#266: FILE: drivers/net/mlx5/lib/mlx5_dll.c:122:
+ return __MLX5_IBVERBS_FUNC(fork_init,);
^
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(ibv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(ibv_##name)(__VA_ARGS__)
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#517: FILE: drivers/net/mlx5/lib/mlx5_dll.h:73:
+#define MLX5_DLSYM_IBVERBS_FUNC(handle, name) do { (void)handle; } while (0)
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+ ret(mlx5dv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+ ret(mlx5dv_##name)(__VA_ARGS__)
total: 4 errors, 1 warnings, 670 lines checked
parent reply other threads:[~2017-12-31 7:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <d17b90a4d765004f878e846b1bde1da6e954306f.1514706323.git.shacharbe@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171231075352.50EC72C08@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=shacharbe@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).