From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 50EC72C08; Sun, 31 Dec 2017 08:53:52 +0100 (CET)
In-Reply-To: <d17b90a4d765004f878e846b1bde1da6e954306f.1514706323.git.shacharbe@mellanox.com>
References: <d17b90a4d765004f878e846b1bde1da6e954306f.1514706323.git.shacharbe@mellanox.com>
To: test-report@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Message-Id: <20171231075352.50EC72C08@dpdk.org>
Date: Sun, 31 Dec 2017 08:53:52 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw32816 [PATCH v4] net/mlx5: load
	libmlx5 and libibverbs in run-time
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Dec 2017 07:53:52 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32816

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxB)
#266: FILE: drivers/net/mlx5/lib/mlx5_dll.c:122:
+	return __MLX5_IBVERBS_FUNC(fork_init,);
 	                                    ^

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+	ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+	ret(ibv_##name)(__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+	ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+	ret(ibv_##name)(__VA_ARGS__)

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+	ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+	ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+	ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+	ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#517: FILE: drivers/net/mlx5/lib/mlx5_dll.h:73:
+#define MLX5_DLSYM_IBVERBS_FUNC(handle, name) do { (void)handle; } while (0)

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+	ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+	ret(mlx5dv_##name)(__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+	ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+	ret(mlx5dv_##name)(__VA_ARGS__)

total: 4 errors, 1 warnings, 670 lines checked