* [dpdk-test-report] |WARNING| pw32816 [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time
[not found] <d17b90a4d765004f878e846b1bde1da6e954306f.1514706323.git.shacharbe@mellanox.com>
@ 2017-12-31 7:53 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-12-31 7:53 UTC (permalink / raw)
To: test-report; +Cc: Shachar Beiser
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32816
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxB)
#266: FILE: drivers/net/mlx5/lib/mlx5_dll.c:122:
+ return __MLX5_IBVERBS_FUNC(fork_init,);
^
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(ibv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#489: FILE: drivers/net/mlx5/lib/mlx5_dll.h:45:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(ibv_##name)(__VA_ARGS__)
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#510: FILE: drivers/net/mlx5/lib/mlx5_dll.h:66:
+#define MLX5_IBVERBS_FUNC(name, ret, ...) \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__); \
+ ret(___mlx5_pmd_ibv_##name)(__VA_ARGS__)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#517: FILE: drivers/net/mlx5/lib/mlx5_dll.h:73:
+#define MLX5_DLSYM_IBVERBS_FUNC(handle, name) do { (void)handle; } while (0)
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+ ret(mlx5dv_##name)(__VA_ARGS__)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects?
#521: FILE: drivers/net/mlx5/lib/mlx5_dll.h:77:
+#define MLX5_MLX5DV_FUNC(name, ret, ...) \
+ ret(*__mlx5_pmd_mlx5dv_##name)(__VA_ARGS__); \
+ ret(mlx5dv_##name)(__VA_ARGS__)
total: 4 errors, 1 warnings, 670 lines checked
^ permalink raw reply [flat|nested] only message in thread