automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Moti H <motih@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw32907 [PATCH 1/2] net/tap: convert to new Tx offloads API
Date: Thu,  4 Jan 2018 19:28:05 +0100 (CET)	[thread overview]
Message-ID: <20180104182805.EB9141B00B@dpdk.org> (raw)
In-Reply-To: <1515090354-183605-2-git-send-email-motih@mellanox.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32907

_coding style issues_


ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("ethdev: introduce Tx queue offloads API")'
#16: 
commit cba7f53 ("ethdev: introduce Tx queue offloads API")

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_conf != NULL'
#146: FILE: drivers/net/tap/rte_eth_tap.c:1123:
+	if ((tx_conf != NULL) &&
+	    !!(tx_conf->txq_flags & ETH_TXQ_FLAGS_IGNORE)) {

total: 1 errors, 0 warnings, 1 checks, 149 lines checked

           reply	other threads:[~2018-01-04 18:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1515090354-183605-2-git-send-email-motih@mellanox.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104182805.EB9141B00B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=motih@mellanox.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).