From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 5B8FF1B04C; Fri, 5 Jan 2018 10:54:16 +0100 (CET) In-Reply-To: <1515145938-97474-6-git-send-email-Ravi1.kumar@amd.com> References: <1515145938-97474-6-git-send-email-Ravi1.kumar@amd.com> To: test-report@dpdk.org Cc: Ravi Kumar Message-Id: <20180105095416.5B8FF1B04C@dpdk.org> Date: Fri, 5 Jan 2018 10:54:16 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw32971 [PATCH v2 06/16] net/axgbe: add phy programming apis X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 09:54:16 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/32971 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #536: FILE: drivers/net/axgbe/axgbe_mdio.c:591: + if (!(pdata->phy.advertising & ADVERTISED_1000baseKX_Full) && CHECK:CAMELCASE: Avoid CamelCase: #537: FILE: drivers/net/axgbe/axgbe_mdio.c:592: + !(pdata->phy.advertising & ADVERTISED_2500baseX_Full)) CHECK:CAMELCASE: Avoid CamelCase: #545: FILE: drivers/net/axgbe/axgbe_mdio.c:600: + if (!(pdata->phy.advertising & ADVERTISED_10000baseKR_Full)) CHECK:CAMELCASE: Avoid CamelCase: #683: FILE: drivers/net/axgbe/axgbe_mdio.c:738: + if (advertising & ADVERTISED_10000baseR_FEC) CHECK:CAMELCASE: Avoid CamelCase: #707: FILE: drivers/net/axgbe/axgbe_mdio.c:762: + if (advertising & ADVERTISED_Pause) CHECK:CAMELCASE: Avoid CamelCase: #712: FILE: drivers/net/axgbe/axgbe_mdio.c:767: + if (advertising & ADVERTISED_Asym_Pause) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pdata->phy.autoneg != AUTONEG_ENABLE' #892: FILE: drivers/net/axgbe/axgbe_mdio.c:947: + if ((pdata->phy.autoneg != AUTONEG_ENABLE) || pdata->parallel_detect) CHECK:CAMELCASE: Avoid CamelCase: #1273: FILE: drivers/net/axgbe/axgbe_phy_impl.c:581: + pdata->phy.advertising &= ~ADVERTISED_Autoneg; CHECK:CAMELCASE: Avoid CamelCase: #1276: FILE: drivers/net/axgbe/axgbe_phy_impl.c:584: + pdata->phy.advertising &= ~ADVERTISED_100baseT_Full; CHECK:CAMELCASE: Avoid CamelCase: #1277: FILE: drivers/net/axgbe/axgbe_phy_impl.c:585: + pdata->phy.advertising &= ~ADVERTISED_1000baseT_Full; CHECK:CAMELCASE: Avoid CamelCase: #1278: FILE: drivers/net/axgbe/axgbe_phy_impl.c:586: + pdata->phy.advertising &= ~ADVERTISED_10000baseT_Full; CHECK:CAMELCASE: Avoid CamelCase: #1647: FILE: drivers/net/axgbe/axgbe_phy_impl.c:955: + pdata->phy.lp_advertising |= ADVERTISED_Backplane; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->port_mode == AXGBE_PORT_MODE_SFP' #1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231: + if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) && + (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) && + (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX' #1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231: + if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) && + (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) && + (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR' #1923: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231: + if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) && + (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) && + (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR)) total: 0 errors, 0 warnings, 15 checks, 2428 lines checked