* [dpdk-test-report] |WARNING| pw33090 [PATCH v4 01/11] eal: add common test assert macros
[not found] <20180108134742.30857-1-pbhagavatula@caviumnetworks.com>
@ 2018-01-08 13:49 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-01-08 13:49 UTC (permalink / raw)
To: test-report; +Cc: Pavan Nikhilesh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33090
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#71: FILE: lib/librte_eal/common/include/rte_test.h:10:
+#define RTE_TEST_ASSERT(cond, msg, ...) do { \
+ if (!(cond)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#79: FILE: lib/librte_eal/common/include/rte_test.h:18:
+#define RTE_TEST_ASSERT_EQUAL(a, b, msg, ...) do { \
+ if (!(a == b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#87: FILE: lib/librte_eal/common/include/rte_test.h:26:
+#define RTE_TEST_ASSERT_NOT_EQUAL(a, b, msg, ...) do { \
+ if (!(a != b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#95: FILE: lib/librte_eal/common/include/rte_test.h:34:
+#define RTE_TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+ typeof(val) _val = (val); \
+ if (!(_val == 0)) { \
+ RTE_LOG(DEBUG, EAL, \
+ "Test assert %s line %d failed (err %d): " \
+ msg "
", __func__, __LINE__, _val, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#106: FILE: lib/librte_eal/common/include/rte_test.h:45:
+#define RTE_TEST_ASSERT_FAIL(val, msg, ...) do { \
+ if (!(val != 0)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#114: FILE: lib/librte_eal/common/include/rte_test.h:53:
+#define RTE_TEST_ASSERT_NULL(val, msg, ...) do { \
+ if (!(val == NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#122: FILE: lib/librte_eal/common/include/rte_test.h:61:
+#define RTE_TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+ if (!(val != NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
total: 0 errors, 7 warnings, 77 lines checked
^ permalink raw reply [flat|nested] only message in thread