* [dpdk-test-report] |WARNING| pw33103 [PATCH v4 1/5] lib: add Port Representor library
[not found] <20180108143720.7994-2-remy.horton@intel.com>
@ 2018-01-08 14:38 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-01-08 14:38 UTC (permalink / raw)
To: test-report; +Cc: Remy Horton
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33103
_coding style issues_
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#66: FILE: MAINTAINERS:779:
+M: Declan Doherty <declan.doherty@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#67: FILE: MAINTAINERS:780:
+M: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#68: FILE: MAINTAINERS:781:
+M: Remy Horton <remy.horton@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#69: FILE: MAINTAINERS:782:
+F: lib/librte_representor
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#70: FILE: MAINTAINERS:783:
+F: doc/guides/prog_guide/representor_lib.rst
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#297: FILE: lib/librte_representor/rte_port_representor.c:24:
+#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed, ret= %d", (retval)); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#304: FILE: lib/librte_representor/rte_port_representor.c:31:
+#define RTE_VERIFY_OR_RET(val) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed"); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#373: FILE: lib/librte_representor/rte_port_representor.c:100:
+#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \
+ if (!strstr(ethdev->data->name, RTE_PORT_REPRESENTOR_DEVICE_NAME)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#381: FILE: lib/librte_representor/rte_port_representor.c:108:
+#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \
+ if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \
+ RTE_PMD_DEBUG_TRACE("Vport is not a representor port"); \
+ return retval; \
+ } \
+} while (0)
total: 0 errors, 9 warnings, 702 lines checked
^ permalink raw reply [flat|nested] only message in thread