automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gage Eads <gage.eads@intel.com>
Subject: [dpdk-test-report] |WARNING| pw33128 [PATCH 2/2] event/sw: use dynamically-sized IQs
Date: Mon,  8 Jan 2018 19:37:22 +0100 (CET)	[thread overview]
Message-ID: <20180108183722.C5A971B1D0@dpdk.org> (raw)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33128

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
Thanks for the report and the GDB output. We've reproduced this and traced it down to how the PMD (mis)handles the re-configuration case. When the SW PMD is reconfigured, it reallocates the IQ chunks and reinitializes the chunk freelist, but it doesn't delete the stale pointers in sw->qids[*].iq. This causes multiple references to the same IQ memory to exist in the system, eventually resulting in the segfault.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#284: FILE: drivers/event/sw/sw_evdev.c:438:
        if (sw->chunks)
+               return 0;

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 3 warnings, 8 lines checked

           reply	other threads:[~2018-01-08 18:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108183722.C5A971B1D0@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).