automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw33128 [PATCH 2/2] event/sw: use dynamically-sized IQs
       [not found] <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>
@ 2018-01-08 18:37 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-01-08 18:37 UTC (permalink / raw)
  To: test-report; +Cc: Gage Eads

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33128

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
Thanks for the report and the GDB output. We've reproduced this and traced it down to how the PMD (mis)handles the re-configuration case. When the SW PMD is reconfigured, it reallocates the IQ chunks and reinitializes the chunk freelist, but it doesn't delete the stale pointers in sw->qids[*].iq. This causes multiple references to the same IQ memory to exist in the system, eventually resulting in the segfault.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#284: FILE: drivers/event/sw/sw_evdev.c:438:
        if (sw->chunks)
+               return 0;

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 3 warnings, 8 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-08 18:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>
2018-01-08 18:37 ` [dpdk-test-report] |WARNING| pw33128 [PATCH 2/2] event/sw: use dynamically-sized IQs checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).