From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C5A971B1D0; Mon,  8 Jan 2018 19:37:22 +0100 (CET)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>
References: <9184057F7FC11744A2107296B6B8EB1E369CDE01@fmsmsx101.amr.corp.intel.com>
To: test-report@dpdk.org
Cc: Gage Eads <gage.eads@intel.com>
Message-Id: <20180108183722.C5A971B1D0@dpdk.org>
Date: Mon,  8 Jan 2018 19:37:22 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw33128 [PATCH 2/2] event/sw: use
	dynamically-sized IQs
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 18:37:22 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33128

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
Thanks for the report and the GDB output. We've reproduced this and traced it down to how the PMD (mis)handles the re-configuration case. When the SW PMD is reconfigured, it reallocates the IQ chunks and reinitializes the chunk freelist, but it doesn't delete the stale pointers in sw->qids[*].iq. This causes multiple references to the same IQ memory to exist in the system, eventually resulting in the segfault.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#284: FILE: drivers/event/sw/sw_evdev.c:438:
        if (sw->chunks)
+               return 0;

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/event/sw/sw_evdev.c:439:
+               return 0;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 3 warnings, 8 lines checked