From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A23B71B1A4; Tue,  9 Jan 2018 13:12:55 +0100 (CET)
In-Reply-To: <20180109121057.59750-11-ferruh.yigit@intel.com>
References: <20180109121057.59750-11-ferruh.yigit@intel.com>
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Message-Id: <20180109121255.A23B71B1A4@dpdk.org>
Date: Tue,  9 Jan 2018 13:12:55 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw33177 [PATCH v2 11/12] net/qede:
	implement dynamic logging
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 12:12:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33177

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#92: FILE: drivers/net/qede/qede_logs.h:14:
+#define DP_ERR(p_dev, fmt, ...)				\
+	rte_log(RTE_LOG_ERR, qede_logtype_driver,	\
+		"[%s:%d(%s)]" fmt,			\
+		__func__, __LINE__,			\
+		(p_dev)->name ? (p_dev)->name : "",	\
 		##__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#140: FILE: drivers/net/qede/qede_logs.h:48:
+#define DP_VERBOSE(p_dev, module, fmt, ...)				\
+	do {								\
+		if ((p_dev)->dp_module & module)			\
+			rte_log(RTE_LOG_DEBUG, qede_logtype_driver,	\
+				"[%s:%d(%s)]" fmt,			\
+				__func__, __LINE__,			\
+				(p_dev)->name ? (p_dev)->name : "",	\
+				##__VA_ARGS__);				\
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 117 lines checked