automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-test-report] |WARNING| pw33263 [PATCH v2 3/6] ethdev: separate internal structures into own header
Date: Tue,  9 Jan 2018 17:24:33 +0100 (CET)	[thread overview]
Message-ID: <20180109162433.BEE6E1B01F@dpdk.org> (raw)
In-Reply-To: <20180109162317.18183-3-ferruh.yigit@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33263

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#761: FILE: lib/librte_ether/rte_ethdev_core.h:89:
+	struct rte_eth_xstat *stats, unsigned n);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#774: FILE: lib/librte_ether/rte_ethdev_core.h:102:
+	struct rte_eth_xstat_name *xstats_names, unsigned size);

WARNING:TYPO_SPELLING: 'informations' may be misspelled - perhaps 'information'?
#790: FILE: lib/librte_ether/rte_ethdev_core.h:118:
+/**< @internal Get specific informations of an Ethernet device. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1080: FILE: lib/librte_ether/rte_ethdev_core.h:408:
+	eth_xstats_reset_t         xstats_reset;  /**< Reset extended device statistics. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1097: FILE: lib/librte_ether/rte_ethdev_core.h:425:
+	vlan_pvid_set_t            vlan_pvid_set; /**< Set port based TX VLAN insertion. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1112: FILE: lib/librte_ether/rte_ethdev_core.h:440:
+	eth_rx_enable_intr_t       rx_queue_intr_enable;  /**< Enable Rx queue interrupt. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1113: FILE: lib/librte_ether/rte_ethdev_core.h:441:
+	eth_rx_disable_intr_t      rx_queue_intr_disable; /**< Disable Rx queue interrupt. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1123: FILE: lib/librte_ether/rte_ethdev_core.h:451:
+	priority_flow_ctrl_set_t   priority_flow_ctrl_set; /**< Setup priority flow control. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1126: FILE: lib/librte_ether/rte_ethdev_core.h:454:
+	eth_uc_all_hash_table_set_t uc_all_hash_table_set; /**< Set Unicast hash bitmap. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1141: FILE: lib/librte_ether/rte_ethdev_core.h:469:
+	rss_hash_conf_get_t        rss_hash_conf_get; /** Get current RSS hash configuration. */

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1261: FILE: lib/librte_ether/rte_ethdev_core.h:589:
+	struct ether_addr* mac_addrs;/**< Device Ethernet Link address. */

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1264: FILE: lib/librte_ether/rte_ethdev_core.h:592:
+	struct ether_addr* hash_mac_addrs;

total: 2 errors, 10 warnings, 1235 lines checked

           reply	other threads:[~2018-01-09 16:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180109162317.18183-3-ferruh.yigit@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109162433.BEE6E1B01F@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).