automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shahaf Shuler <shahafs@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw33386 [PATCH v3 5/7] net/mlx5: convert to new Rx offloads API
Date: Wed, 10 Jan 2018 10:18:04 +0100 (CET)	[thread overview]
Message-ID: <20180110091804.911AB1B238@dpdk.org> (raw)
In-Reply-To: <11bc8d8ca32307daf82753e69aa52e2414dd7644.1515575671.git.shahafs@mellanox.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33386

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#50: FILE: drivers/net/mlx5/mlx5_ethdev.c:569:
+		      "requested 0x%" PRIx64 " supported 0x%" PRIx64,

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#52: FILE: drivers/net/mlx5/mlx5_ethdev.c:571:
+		return ENOTSUP;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#254: FILE: drivers/net/mlx5/mlx5_rxtx.h:277:
+uint64_t mlx5_priv_get_rx_port_offloads(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#255: FILE: drivers/net/mlx5/mlx5_rxtx.h:278:
+uint64_t mlx5_priv_get_rx_queue_offloads(struct priv *);

total: 0 errors, 3 warnings, 1 checks, 215 lines checked

           reply	other threads:[~2018-01-10  9:18 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <11bc8d8ca32307daf82753e69aa52e2414dd7644.1515575671.git.shahafs@mellanox.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110091804.911AB1B238@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).