From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 911AB1B238; Wed, 10 Jan 2018 10:18:04 +0100 (CET)
In-Reply-To: <11bc8d8ca32307daf82753e69aa52e2414dd7644.1515575671.git.shahafs@mellanox.com>
References: <11bc8d8ca32307daf82753e69aa52e2414dd7644.1515575671.git.shahafs@mellanox.com>
To: test-report@dpdk.org
Cc: Shahaf Shuler <shahafs@mellanox.com>
Message-Id: <20180110091804.911AB1B238@dpdk.org>
Date: Wed, 10 Jan 2018 10:18:04 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw33386 [PATCH v3 5/7] net/mlx5:
	convert to new Rx offloads API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 09:18:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33386

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#50: FILE: drivers/net/mlx5/mlx5_ethdev.c:569:
+		      "requested 0x%" PRIx64 " supported 0x%" PRIx64,

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#52: FILE: drivers/net/mlx5/mlx5_ethdev.c:571:
+		return ENOTSUP;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#254: FILE: drivers/net/mlx5/mlx5_rxtx.h:277:
+uint64_t mlx5_priv_get_rx_port_offloads(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#255: FILE: drivers/net/mlx5/mlx5_rxtx.h:278:
+uint64_t mlx5_priv_get_rx_queue_offloads(struct priv *);

total: 0 errors, 3 warnings, 1 checks, 215 lines checked