From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Remy Horton <remy.horton@intel.com>
Subject: [dpdk-test-report] |WARNING| pw33507 [PATCH v5 1/5] lib: add Port Representor library
Date: Wed, 10 Jan 2018 16:55:45 +0100 (CET) [thread overview]
Message-ID: <20180110155545.F41D21B26E@dpdk.org> (raw)
In-Reply-To: <20180110155406.17428-2-remy.horton@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33507
_coding style issues_
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#67: FILE: MAINTAINERS:785:
+M: Declan Doherty <declan.doherty@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#68: FILE: MAINTAINERS:786:
+M: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#69: FILE: MAINTAINERS:787:
+M: Remy Horton <remy.horton@intel.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#70: FILE: MAINTAINERS:788:
+F: lib/librte_representor
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#71: FILE: MAINTAINERS:789:
+F: doc/guides/prog_guide/representor_lib.rst
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#333: FILE: lib/librte_representor/rte_port_representor.c:25:
+#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \
+ if (!(val)) { \
+ RTE_LOG(DEBUG, PORTREP, "verify failed, ret= %d", (retval)); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#340: FILE: lib/librte_representor/rte_port_representor.c:32:
+#define RTE_VERIFY_OR_RET(val) do { \
+ if (!(val)) { \
+ RTE_LOG(DEBUG, PORTREP, "verify failed"); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#409: FILE: lib/librte_representor/rte_port_representor.c:101:
+#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \
+ if (!strstr(ethdev->data->name, RTE_PORT_REPRESENTOR_DEVICE_NAME)) { \
+ RTE_LOG(DEBUG, PORTREP, "port %d is not a representor port", \
+ ethdev->data->port_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#417: FILE: lib/librte_representor/rte_port_representor.c:109:
+#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \
+ if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \
+ RTE_LOG(DEBUG, PORTREP, "Vport is not a representor port"); \
+ return retval; \
+ } \
+} while (0)
total: 0 errors, 9 warnings, 746 lines checked
parent reply other threads:[~2018-01-10 15:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180110155406.17428-2-remy.horton@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110155545.F41D21B26E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=remy.horton@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).