From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id F41D21B26E; Wed, 10 Jan 2018 16:55:45 +0100 (CET) In-Reply-To: <20180110155406.17428-2-remy.horton@intel.com> References: <20180110155406.17428-2-remy.horton@intel.com> To: test-report@dpdk.org Cc: Remy Horton Message-Id: <20180110155545.F41D21B26E@dpdk.org> Date: Wed, 10 Jan 2018 16:55:45 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw33507 [PATCH v5 1/5] lib: add Port Representor library X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 15:55:46 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/33507 _coding style issues_ WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE: #67: FILE: MAINTAINERS:785: +M: Declan Doherty WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE: #68: FILE: MAINTAINERS:786: +M: Mohammad Abdul Awal WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE: #69: FILE: MAINTAINERS:787: +M: Remy Horton WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE: #70: FILE: MAINTAINERS:788: +F: lib/librte_representor WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE: #71: FILE: MAINTAINERS:789: +F: doc/guides/prog_guide/representor_lib.rst WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #333: FILE: lib/librte_representor/rte_port_representor.c:25: +#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \ + if (!(val)) { \ + RTE_LOG(DEBUG, PORTREP, "verify failed, ret= %d", (retval)); \ + return retval; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #340: FILE: lib/librte_representor/rte_port_representor.c:32: +#define RTE_VERIFY_OR_RET(val) do { \ + if (!(val)) { \ + RTE_LOG(DEBUG, PORTREP, "verify failed"); \ + return; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #409: FILE: lib/librte_representor/rte_port_representor.c:101: +#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \ + if (!strstr(ethdev->data->name, RTE_PORT_REPRESENTOR_DEVICE_NAME)) { \ + RTE_LOG(DEBUG, PORTREP, "port %d is not a representor port", \ + ethdev->data->port_id); \ + return retval; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #417: FILE: lib/librte_representor/rte_port_representor.c:109: +#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \ + if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \ + RTE_LOG(DEBUG, PORTREP, "Vport is not a representor port"); \ + return retval; \ + } \ +} while (0) total: 0 errors, 9 warnings, 746 lines checked