From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id AE39E1B1B6; Thu, 11 Jan 2018 20:24:24 +0100 (CET)
In-Reply-To: <1515698603-20416-4-git-send-email-amr.mokhtar@intel.com>
References: <1515698603-20416-4-git-send-email-amr.mokhtar@intel.com>
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Message-Id: <20180111192424.AE39E1B1B6@dpdk.org>
Date: Thu, 11 Jan 2018 20:24:24 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw33638 [PATCH v5 4/5] bbdev: test
	applications
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 19:24:24 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33638

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#70: FILE: MAINTAINERS:278:
+F: app/test-bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#73: FILE: MAINTAINERS:281:
+F: doc/guides/tools/testbbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#477: FILE: app/test-bbdev/main.h:23:
+#define TEST_ASSERT(cond, msg, ...) do {  \
+		if (!(cond)) {  \
+			printf("TestCase %s() line %d failed: " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#486: FILE: app/test-bbdev/main.h:32:
+#define TEST_ASSERT_BUFFERS_ARE_EQUAL(a, b, len, msg, ...) do { \
+	if (memcmp((a), (b), len)) { \
+		printf("TestCase %s() line %d failed: " \
+			msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+		rte_memdump(stdout, "Buffer A", (a), len); \
+		rte_memdump(stdout, "Buffer B", (b), len); \
+		return TEST_FAILED; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#496: FILE: app/test-bbdev/main.h:42:
+#define TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+		typeof(val) _val = (val); \
+		if (!(_val == 0)) { \
+			printf("TestCase %s() line %d failed (err %d): " \
+				msg "
", __func__, __LINE__, _val, \
+				##__VA_ARGS__); \
+			return TEST_FAILED; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#509: FILE: app/test-bbdev/main.h:55:
+#define TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+		if ((val) == NULL) { \
+			printf("TestCase %s() line %d failed (null): " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

total: 0 errors, 6 warnings, 5763 lines checked