From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zhike Wang <wangzhike@jd.com>
Subject: [dpdk-test-report] |WARNING| pw33911 [PATCH v3] lib/librte_vhost: move fdset_del out of conn_mutex
Date: Wed, 17 Jan 2018 11:51:18 +0100 (CET) [thread overview]
Message-ID: <20180117105118.592C31B052@dpdk.org> (raw)
In-Reply-To: <6DAF063A35010343823807B082E5681F41D89369@mbx05.360buyAD.local>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/33911
_coding style issues_
ERROR:BAD_SIGN_OFF: Unrecognized email address: '王志克\r'
#25:
Cc: 王志克
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#26:
Subject: [PATCH v3] [PATCH] lib/librte_vhost: move fdset_del out of conn_mutex
ERROR:DOS_LINE_ENDINGS: DOS line endings
#63: FILE: lib/librte_vhost/socket.c:752:
+^I^I^Iint del_fds[MAX_FDS];^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#64: FILE: lib/librte_vhost/socket.c:753:
+^I^I^Iint num_of_fds = 0, fd_index;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#65: FILE: lib/librte_vhost/socket.c:754:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: lib/librte_vhost/socket.c:763:
+^I^I^I/* fdset_del() must be called without conn_mutex. */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#74: FILE: lib/librte_vhost/socket.c:764:
+^I^I^Ipthread_mutex_lock(&vsocket->conn_mutex);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#75: FILE: lib/librte_vhost/socket.c:765:
+^I^I^Ifor (conn = TAILQ_FIRST(&vsocket->conn_list);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#76: FILE: lib/librte_vhost/socket.c:766:
+^I^I^I conn != NULL;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#77: FILE: lib/librte_vhost/socket.c:767:
+^I^I^I conn = next) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: lib/librte_vhost/socket.c:768:
+^I^I^I^Inext = TAILQ_NEXT(conn, next);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#79: FILE: lib/librte_vhost/socket.c:769:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#80: FILE: lib/librte_vhost/socket.c:770:
+^I^I^I^Idel_fds[num_of_fds++] = conn->connfd;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#81: FILE: lib/librte_vhost/socket.c:771:
+^I^I^I}^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#82: FILE: lib/librte_vhost/socket.c:772:
+^I^I^Ipthread_mutex_unlock(&vsocket->conn_mutex);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#83: FILE: lib/librte_vhost/socket.c:773:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#84: FILE: lib/librte_vhost/socket.c:774:
+^I^I^Ifor (fd_index = 0; fd_index < num_of_fds; fd_index++)^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#85: FILE: lib/librte_vhost/socket.c:775:
+^I^I^I^Ifdset_del(&vhost_user.fdset, del_fds[fd_index]);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#86: FILE: lib/librte_vhost/socket.c:776:
+^M$
total: 18 errors, 1 warnings, 36 lines checked
parent reply other threads:[~2018-01-17 10:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <6DAF063A35010343823807B082E5681F41D89369@mbx05.360buyAD.local>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117105118.592C31B052@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wangzhike@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).