From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw34109 [PATCH RFC 15/24] vhost: add virtio pci framework
Date: Fri, 19 Jan 2018 14:47:57 +0100 (CET) [thread overview]
Message-ID: <20180119134757.2A86E1B324@dpdk.org> (raw)
In-Reply-To: <20180119134444.24927-16-stefanha@redhat.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34109
_coding style issues_
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#101: FILE: drivers/librte_vhost/virtio_pci.h:44:
+ * also clears the register (8, RO) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#105: FILE: drivers/librte_vhost/virtio_pci.h:48:
+#define VIRTIO_MSI_QUEUE_VECTOR 22 /* vector for selected VQ notifications
+ (16, RW) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#105: FILE: drivers/librte_vhost/virtio_pci.h:48:
+ (16, RW) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#138: FILE: drivers/librte_vhost/virtio_pci.h:81:
+ * suppressed them? */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#159: FILE: drivers/librte_vhost/virtio_pci.h:102:
+ * at the end of the avail ring. Host should ignore the avail->flags field. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#161: FILE: drivers/librte_vhost/virtio_pci.h:104:
+ * at the end of the used ring. Guest should ignore the used->flags field. */
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#305: FILE: drivers/librte_vhost/virtio_pci.h:248:
+void virtio_pci_reset(struct virtio_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#307: FILE: drivers/librte_vhost/virtio_pci.h:250:
+void virtio_pci_reinit_complete(struct virtio_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#309: FILE: drivers/librte_vhost/virtio_pci.h:252:
+uint8_t virtio_pci_get_status(struct virtio_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#310: FILE: drivers/librte_vhost/virtio_pci.h:253:
+void virtio_pci_set_status(struct virtio_hw *, uint8_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#310: FILE: drivers/librte_vhost/virtio_pci.h:253:
+void virtio_pci_set_status(struct virtio_hw *, uint8_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#312: FILE: drivers/librte_vhost/virtio_pci.h:255:
+uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#312: FILE: drivers/librte_vhost/virtio_pci.h:255:
+uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#314: FILE: drivers/librte_vhost/virtio_pci.h:257:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#314: FILE: drivers/librte_vhost/virtio_pci.h:257:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const void *' should also have an identifier name
#314: FILE: drivers/librte_vhost/virtio_pci.h:257:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#314: FILE: drivers/librte_vhost/virtio_pci.h:257:
+void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#316: FILE: drivers/librte_vhost/virtio_pci.h:259:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#316: FILE: drivers/librte_vhost/virtio_pci.h:259:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#316: FILE: drivers/librte_vhost/virtio_pci.h:259:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#316: FILE: drivers/librte_vhost/virtio_pci.h:259:
+void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name
#318: FILE: drivers/librte_vhost/virtio_pci.h:261:
+uint8_t virtio_pci_isr(struct virtio_hw *);
total: 0 errors, 22 warnings, 962 lines checked
parent reply other threads:[~2018-01-19 13:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180119134444.24927-16-stefanha@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119134757.2A86E1B324@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stefanha@redhat.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).