From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 2A86E1B324; Fri, 19 Jan 2018 14:47:57 +0100 (CET) In-Reply-To: <20180119134444.24927-16-stefanha@redhat.com> References: <20180119134444.24927-16-stefanha@redhat.com> To: test-report@dpdk.org Cc: Stefan Hajnoczi Message-Id: <20180119134757.2A86E1B324@dpdk.org> Date: Fri, 19 Jan 2018 14:47:57 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw34109 [PATCH RFC 15/24] vhost: add virtio pci framework X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 13:47:57 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/34109 _coding style issues_ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #101: FILE: drivers/librte_vhost/virtio_pci.h:44: + * also clears the register (8, RO) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #105: FILE: drivers/librte_vhost/virtio_pci.h:48: +#define VIRTIO_MSI_QUEUE_VECTOR 22 /* vector for selected VQ notifications + (16, RW) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #105: FILE: drivers/librte_vhost/virtio_pci.h:48: + (16, RW) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #138: FILE: drivers/librte_vhost/virtio_pci.h:81: + * suppressed them? */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #159: FILE: drivers/librte_vhost/virtio_pci.h:102: + * at the end of the avail ring. Host should ignore the avail->flags field. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #161: FILE: drivers/librte_vhost/virtio_pci.h:104: + * at the end of the used ring. Guest should ignore the used->flags field. */ WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #305: FILE: drivers/librte_vhost/virtio_pci.h:248: +void virtio_pci_reset(struct virtio_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #307: FILE: drivers/librte_vhost/virtio_pci.h:250: +void virtio_pci_reinit_complete(struct virtio_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #309: FILE: drivers/librte_vhost/virtio_pci.h:252: +uint8_t virtio_pci_get_status(struct virtio_hw *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #310: FILE: drivers/librte_vhost/virtio_pci.h:253: +void virtio_pci_set_status(struct virtio_hw *, uint8_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name #310: FILE: drivers/librte_vhost/virtio_pci.h:253: +void virtio_pci_set_status(struct virtio_hw *, uint8_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #312: FILE: drivers/librte_vhost/virtio_pci.h:255: +uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name #312: FILE: drivers/librte_vhost/virtio_pci.h:255: +uint64_t virtio_pci_negotiate_features(struct virtio_hw *, uint64_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #314: FILE: drivers/librte_vhost/virtio_pci.h:257: +void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name #314: FILE: drivers/librte_vhost/virtio_pci.h:257: +void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'const void *' should also have an identifier name #314: FILE: drivers/librte_vhost/virtio_pci.h:257: +void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #314: FILE: drivers/librte_vhost/virtio_pci.h:257: +void virtio_pci_write_dev_config(struct virtio_hw *, size_t, const void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #316: FILE: drivers/librte_vhost/virtio_pci.h:259: +void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name #316: FILE: drivers/librte_vhost/virtio_pci.h:259: +void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #316: FILE: drivers/librte_vhost/virtio_pci.h:259: +void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name #316: FILE: drivers/librte_vhost/virtio_pci.h:259: +void virtio_pci_read_dev_config(struct virtio_hw *, size_t, void *, int); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct virtio_hw *' should also have an identifier name #318: FILE: drivers/librte_vhost/virtio_pci.h:261: +uint8_t virtio_pci_isr(struct virtio_hw *); total: 0 errors, 22 warnings, 962 lines checked