From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DB51C1B16D; Mon, 22 Jan 2018 00:36:46 +0100 (CET)
In-Reply-To: <20180121233533.95629-2-ferruh.yigit@intel.com>
References: <20180121233533.95629-2-ferruh.yigit@intel.com>
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Message-Id: <20180121233646.DB51C1B16D@dpdk.org>
Date: Mon, 22 Jan 2018 00:36:46 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw34196 [PATCH v5 2/4] ethdev:
	separate internal structures into own header
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jan 2018 23:36:47 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/34196

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#750: FILE: lib/librte_ether/rte_ethdev_core.h:75:
+	struct rte_eth_xstat *stats, unsigned n);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#763: FILE: lib/librte_ether/rte_ethdev_core.h:88:
+	struct rte_eth_xstat_name *xstats_names, unsigned size);

WARNING:TYPO_SPELLING: 'informations' may be misspelled - perhaps 'information'?
#779: FILE: lib/librte_ether/rte_ethdev_core.h:104:
+/**< @internal Get specific informations of an Ethernet device. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1071: FILE: lib/librte_ether/rte_ethdev_core.h:396:
+	eth_xstats_reset_t         xstats_reset;  /**< Reset extended device statistics. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1088: FILE: lib/librte_ether/rte_ethdev_core.h:413:
+	vlan_pvid_set_t            vlan_pvid_set; /**< Set port based TX VLAN insertion. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1103: FILE: lib/librte_ether/rte_ethdev_core.h:428:
+	eth_rx_enable_intr_t       rx_queue_intr_enable;  /**< Enable Rx queue interrupt. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1104: FILE: lib/librte_ether/rte_ethdev_core.h:429:
+	eth_rx_disable_intr_t      rx_queue_intr_disable; /**< Disable Rx queue interrupt. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1114: FILE: lib/librte_ether/rte_ethdev_core.h:439:
+	priority_flow_ctrl_set_t   priority_flow_ctrl_set; /**< Setup priority flow control. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1117: FILE: lib/librte_ether/rte_ethdev_core.h:442:
+	eth_uc_all_hash_table_set_t uc_all_hash_table_set; /**< Set Unicast hash bitmap. */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1132: FILE: lib/librte_ether/rte_ethdev_core.h:457:
+	rss_hash_conf_get_t        rss_hash_conf_get; /** Get current RSS hash configuration. */

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1252: FILE: lib/librte_ether/rte_ethdev_core.h:577:
+	struct ether_addr* mac_addrs;/**< Device Ethernet Link address. */

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#1255: FILE: lib/librte_ether/rte_ethdev_core.h:580:
+	struct ether_addr* hash_mac_addrs;

total: 2 errors, 10 warnings, 1228 lines checked